Feature #609

Having check box in the web interface for selecting multiple host and services

Added by dnsmichi almost 4 years ago. Updated over 3 years ago.

Status:ResolvedStart date:07/08/2010
Priority:LowDue date:
Assignee:TheFlyingCorpse% Done:

100%

Category:OtherEstimated time:20.00 hours
Target version:Core - 1.0.3

Description

basically sth like icinga web provides, but the classic way. would be hard to read the POST with different selected array ids though, but why not. It's not that different in c/cgi than in php.

Summary       0000053: Having check box in the web interface for selecting multiple host and services
Description     When looking at host problem or service problem page, having check box next to host and service name will be a great addition. This will give user the opportunity to acknowledge multiple problem at the same time. Specially useful during major outages.

Associated revisions

Revision d4789ab7
Added by TheFlyingCorpse over 3 years ago

Added batch selecting hosts and services.
Large changes in cmd.c and status.c
Cleaned up some whitespaces in the other CGI's.

JavaScript dropdown menu
JavaScript enabled checkbox to select everything in the view.
Current limit of around 125 simultaneous commands.

IssueID #609

Revision 3cea114d
Added by dnsmichi over 3 years ago

classic ui: move inline file names/dirs for multiple commands into cgiutils.c/.h

add url_js_path and several #defines in order to maintain it a bit easier,
and also modular when updating versions of jquery etc.

the html path is also not hardcoded anymore, allowing configure params
changing the html base dir.

refs #609

Revision f4b63e95
Added by dnsmichi over 3 years ago

classic ui: change location of multiple commands dropdown

seperating the urls box, and commands dropdown into its
own table makes more sense, not loosing too many space on
small displays.

also added a submit button with js onclick event instead
of a normal selective text url.

refs #609

Revision f2b1c52d
Added by TheFlyingCorpse over 3 years ago

Rewrote the read-checkboxes javascript to be more robust.
Moved several javascripts out of status.c into their own files.
Added in a debug for the URL that can be manually enabled by removing the comment in checkboxesNbutton.js
Fixes 609

Updated scriptalicious to 1.8.3, up from 1.8.2
Fixes #698

Revision 2ad210df
Added by TheFlyingCorpse over 3 years ago

Rewrote the read-checkboxes javascript to be more robust.
Moved several javascripts out of status.c into their own files.
Added in a debug for the URL that can be manually enabled by removing the comment in checkboxesNbutton.js
Fixes #609

Updated scriptalicious to 1.8.3, up from 1.8.2
Fixes #698

History

#1 Updated by dnsmichi almost 4 years ago

  • Tracker changed from Bug to Feature

#2 Updated by dnsmichi over 3 years ago

  • Project changed from Core to Classic UI
  • Category deleted (Classical UI)

#3 Updated by TheFlyingCorpse over 3 years ago

  • Category set to Other
  • Assignee set to TheFlyingCorpse
  • % Done changed from 0 to 30
  • Estimated time set to 12.00

I am working on this.
I've got a basic version of it to work, just need to brush up the HTML and a good way to present all the checks available.

#4 Updated by TheFlyingCorpse over 3 years ago

  • Subject changed from aving check box in the web interface for selecting multiple host and services to Having check box in the web interface for selecting multiple host and services
  • Target version set to 1.2 (Stable)
  • % Done changed from 30 to 50
  • Estimated time changed from 12.00 to 20.00

Done:
Add in checks in status.c
Selection is done via a dropdown menu and a "submit" link.
To select targets, just click in the checkboxes on the page.

ToDo:
Fix HTML so it can be more easy to read these "batch" checks.

#5 Updated by TheFlyingCorpse over 3 years ago

  • % Done changed from 50 to 90

Last thing ToDo:
Extensive testing

Wishlist:
Make a nicer HTML output in cmd.c

#6 Updated by TheFlyingCorpse over 3 years ago

  • Status changed from New to Resolved
  • % Done changed from 90 to 100

Extensive testing done, added 2 missing checks to the command table.

I consider this resolved, fixing up the HTML can be done if the feedback from the current is negative.

#7 Updated by dnsmichi over 3 years ago

  • Status changed from Resolved to Assigned
  • Target version changed from 1.2 (Stable) to 1.0.3
  • % Done changed from 100 to 90

maybe possible to bring this into 1.0.3 ?

see my commit about the path changes.

#8 Updated by TheFlyingCorpse over 3 years ago

I will update the code later today, great to see you added paths(will save hassle later!)

#9 Updated by dnsmichi over 3 years ago

simply do a

$ git checkout master
$ git pull
$ git checkout mfriedrich/core
$ git pull origin mfriedrich/core
$ git checkout rdarrud/cgis
$ git merge mfriedrich/core

then you'll have the latest and greatest.

regarding the location of the command dropdown - i woud prefer having it next to "view service status detail" etc links, and not in the table at the top.

since this is a rather complicated table layout, maybe it's even better to put that right below everything meaning over here:

                /* end of top table */
                printf("</tr>\n"); // <===========
                printf("</table>\n");

#10 Updated by dnsmichi over 3 years ago

i've revamped it a bit, split the top table into 2 tables (id display_header is set), and moved the commands dropdown into the 2nd table on the most right.

the submit text url with a onclick event is now a submit button with onclick event, which fits better into the current layout imho.

some todos:
  • create option to enable/disable reload function
  • add style for all buttons throughout the classic ui, in order to make those things a bit more 'smooth' ;-)

#11 Updated by TheFlyingCorpse over 3 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 90 to 100

Applied in changeset commit:"f2b1c52d9b956dec600012d7ba5f73b8594687d2".

#12 Updated by ricardo over 3 years ago

  • Status changed from Resolved to Feedback
  • % Done changed from 100 to 90

on Windows with Firefox 4 beta3 the DropDown Menu disappears! Con someone confirm this behavior?

#13 Updated by TheFlyingCorpse over 3 years ago

Is firebug available for FireFox 4 beta's? If so, please install it and activate it when you go to the site. Post back any error messages.

#14 Updated by ricardo over 3 years ago

  • % Done changed from 90 to 100

i tested it with Safari for Mac and Windows. Works fine there as well.

Probably better not to test it with a Firefox beta.

And Firebug isn't available for firefox 4b3

#15 Updated by ricardo over 3 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF