Bug #5346

fix vulnerability against CSRF attacks CVE-2013-7107

Added by ricardo over 1 year ago. Updated 4 months ago.

Status:ResolvedStart date:12/16/2013
Priority:NormalDue date:
Assignee:ricardo% Done:

100%

Category:Classic UI
Target version:Icinga 1.x - 1.11
Icinga Version:1.10.2 OS Version:any

Description

this is a follow up to #5250

Answer from "cve-assign at mitre.org"

Because one report mentions CSRF,
our expectation is that some type of CSRF impact would
remain even after the buffer overflows were fixed.

We will fix the problem with these prevention suggestions. (https://www.owasp.org/index.php/Cross-Site_Request_Forgery_(CSRF)_Prevention_Cheat_Sheet#CSRF_Prevention_without_a_Synchronizer_Token)

As Classic-UI is stateless, we will add a check for submitted commands and the HTTP Referrer header and/or Origin header if present.

Associated revisions

Revision bdf8b99f
Added by ricardo over 1 year ago

classic-ui: fix vulnerability against CSRF attacks CVE-2013-7107 #5346

This is the fix for CVE-2013-7107. From now on the HTTP referer gets
checked if the request of cmd.cgi actually comes from cmd.cgi.
Otherwise the request will be rejected and the user be notified if
possible. Also a new cgi.cfg option "disable_cmd_cgi_csrf_protection"
got added to disable the protection and allow external programs to
submit commands.

refs: #5346

Revision acb62711
Added by ricardo over 1 year ago

classic-ui: add change entry in Changelog #5346

refs: #5346

Revision 6df4f60d
Added by ricardo over 1 year ago

Merge branch 'fix/vulnerability-against-CSRF-attacks-5346' into next

Conflicts:
Changelog

fixes: #5346

Revision 46735564
Added by ricardo about 1 year ago

classic-ui: added new config option to config.cgi #5346

refs: #5346

History

#1 Updated by ricardo over 1 year ago

fix in current "fix/vulnerability-against-CSRF-attacks-5346"

THIS ADDS A NEW CGI.CFG OPTION

As it adds a new configuration option and also would break compatibility with current Nagstamon and co installations it will be upstream only from 1.11 on.

cfg.cgi description:

# DISABLE CMD CGI CSRF PROTECTION
# This option disables the protection against CSRF attacks
# (Cross-Site Request Forgery). Use this option only if you are
# using external programs (like Nagstamon) which access
# cmd.cgi directly to submit commands. By default the submitted
# command (via external program) will be rejected.
# The default is 0 (protection is on).

disable_cmd_cgi_csrf_protection=0

Also added patches for
  • 1.10.2
  • 1.9.4
  • 1.8.5

#2 Updated by ricardo about 1 year ago

  • Status changed from New to Resolved
  • % Done changed from 80 to 100

#3 Updated by dnsmichi 4 months ago

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category set to Classic UI
  • OS Version set to any

Also available in: Atom PDF