Feature #2292

Compatibility problems on Solaris 10

Added by crfriend about 2 years ago. Updated about 2 years ago.

Status:ResolvedStart date:01/29/2012
Priority:NormalDue date:
Assignee:dnsmichi% Done:

100%

Category:Installation
Target version:Icinga 1.x - 1.7

Description

When building Icinga 1.6.1 on Solaris 10 (SPARC) with gcc 2.95.3 I ran into several problems with declarations, and null-pointer dereferencing. Attached are five patches which addressed the problems.

patch-checks.c Magnifier - C:\Users\carl\tmp\patch-utils.c (383 Bytes) crfriend, 01/29/2012 03:12 pm

patch-ido2db.c Magnifier (1.88 KB) crfriend, 01/29/2012 03:17 pm

patch-utils.c Magnifier (416 Bytes) crfriend, 01/29/2012 03:19 pm

patch-extinfo.c Magnifier (1.28 KB) crfriend, 01/29/2012 03:19 pm

patch-idomod.c Magnifier (726 Bytes) crfriend, 01/29/2012 03:20 pm

0001-Feature-2292-Compatibility-patches.patch Magnifier - A git patch for everything above. (5.6 KB) crfriend, 01/29/2012 03:45 pm


Related issues

Related to IDOUtils - Bug #2271: unsafe null ptr passed to debug log, segfault on solaris Resolved 01/16/2012

Associated revisions

Revision 96d9c51d
Added by Tommi about 2 years ago

idoutils: apply idomod patch contributed in #2292 for gcc2.95 compatibility
refs #2292

Revision ee2fe6bb
Added by dnsmichi about 2 years ago

core: apply patch from #2292

refs #2292

Revision 7e7f5d85
Added by dnsmichi about 2 years ago

final fix compatibility problems on solaris 10 (Carl R. Friend) #2292

refs #2292

Revision f5b780b3
Added by Tommi about 2 years ago

idoutils: add remaining patch to ido2db #2292
refs #2292

History

#1 Updated by crfriend about 2 years ago

There should be five attachments, patch-(checks|utils|extinfo|idomod|ido2db).c containing fixes to each of those source files. The patches for checks.c and utils.c correct a problem with an undefined variable "n_a" that happens with the embedded perl interpreter enabled. The ones for extinfo.c and idomod.c move declarations to the beginning of functions to correct compilation errors on the old version of gcc. The changes to ido2db correct null-pointer dereferencing and compilation errors when deep debugging is turned on.

#2 Updated by crfriend about 2 years ago

#3 Updated by crfriend about 2 years ago

#4 Updated by crfriend about 2 years ago

#6 Updated by Tommi about 2 years ago

Thanks! I will check this tommorow with suncc.
BTW:You dont need this old gcc, you can use an actual SunStudioExpress as well (after applying some additional patches :-)))
Thomas

#7 Updated by dnsmichi about 2 years ago

see icinga-users mailinglist for previous discussions.

thanks for the patches, should be put by their respective git branches (cgi, core, ido) and not fully applied into one branch.

#8 Updated by dnsmichi about 2 years ago

  • Target version set to 1.7

#9 Updated by crfriend about 2 years ago

dnsmichi wrote:

thanks for the patches, should be put by their respective git branches (cgi, core, ido) and not fully applied into one branch.

You're most welcome, and I shall bear that in mind. Thanks.

#10 Updated by dnsmichi about 2 years ago

that was just an update for the guy taking your patches then (if it won't be me). that's why i was insisting on seperated patches, to allow their applying onto the seperated dev and test branches. on release, they'll get merged together.

#11 Updated by Tommi about 2 years ago

  • Category set to Installation
  • Status changed from New to Assigned
  • Assignee set to ricardo
  • % Done changed from 0 to 20

patch for idomod added
patch for ido2db not added, because logging patches from #2271 should do this more in general. other patches should be checked from core team.for solaris related issues see also #1772 and #1253

#12 Updated by dnsmichi about 2 years ago

core is added, just some minor addins if compiled with embedded perl.

#13 Updated by dnsmichi about 2 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from ricardo to dnsmichi
  • % Done changed from 20 to 100

last one is now in dev/cgis waiting for the merge upstream.

#14 Updated by Tommi about 2 years ago

added changes from patch-ido2db.c which not has been applied before to ido2db in changeset f5b780b389676f9bee4bab44912129f1a21b967c

#15 Updated by dnsmichi about 2 years ago

thanks for the final fix, i'll resolve for now. full merge is to be done.

#16 Updated by dnsmichi about 2 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF