Feature #1777

add highlight_table_rows to status.cgi

Added by dnsmichi over 2 years ago. Updated over 2 years ago.

Status:ResolvedStart date:08/03/2011
Priority:LowDue date:
Assignee:ricardo% Done:

100%

Category:Interface
Target version:Icinga 1.x - 1.6

Description

basically to highlight the current service row, and to find the correct command tickbox on the right. sometimes it can be hard to figure that correctly, mostly on higher resolution and/or many services/hosts.

[10:23:28] <dnsmichi> my coworker just pointed me to that
[10:23:35] <dnsmichi> when you have the status.cgi with many services
[10:23:40] <dnsmichi> and you move your mouse over
[10:23:52] <dnsmichi> over each line, nothing happens
[10:24:00] <dnsmichi> so if there would be a "highlight" 
[10:24:16] <dnsmichi> one could recall the actual service text on the left, and tick the command box on the right
[10:24:24] <mjbrooks> ah... you want a visual line tracking
[10:24:30] <dnsmichi> sometimes you lose focus, and it's always hard to figure
[10:24:31] <dnsmichi> yes
[10:24:42] <dnsmichi> seen that in various guis
[10:24:47] <dnsmichi> and i find it very useful
[10:24:51] <mjbrooks> that would be a nice touch
[10:25:06] <dnsmichi> ok
[10:25:11] <dnsmichi> then i'll open a feature request
[10:25:34] <mjbrooks> I believe that would be a CSS change and fairly straightforward
[10:25:57] <mjbrooks> assuming the current CSS isn't spagghetti

Related issues

Related to Docs - Feature #1790: new cgi.cfg option: highlight_table_rows Resolved 08/06/2011

Associated revisions

Revision 9091cb00
Added by dnsmichi over 2 years ago

classic ui: add highlight_table_rows to status.cgi, can be disabled via cfg option #1777

uses a javascript library to highlight the complete row,
ignoring the nested tables where ids would fail on tr.

cgi.cfg option added to allow ppl to disable it on demand.

refs #1777

Revision c13299ef
Added by ricardo over 2 years ago

classic-ui: diabled highlight_table_rows by default.

refs: #1777

Revision 420db343
Added by ricardo over 2 years ago

classic-ui: reworked highlight_table_rows and set to enabled by default #1777

refs: #1777

  • now enabled by default
  • removed htables.js
  • substitued with a few lines jquery code in status.c

Revision a493e095
Added by ricardo over 2 years ago

classic-ui: highlight_table_rows is now enabled by default in cgi.cfg #1777

refs: #1777

History

#1 Updated by mjbrooks over 2 years ago

  • Priority changed from Normal to Low

Thanks to Microsoft IE being non-standards compliant as well as existing table complications we'll revisit this for a future release.

I definitely like polish like this though.

#2 Updated by dnsmichi over 2 years ago

the main problem is that the status table consists of sub tables, for each row and column, there's a sub table with a background colour and so on.

so by just selecting a table row, this probably won't fit.
http://www.permadi.com/tutorial/cssHighlightTableRow/index.html

#3 Updated by dnsmichi over 2 years ago

  • Subject changed from add visual line tracking to status.cgi to add highlight_table_rows to status.cgi, disabled via cfg option
  • Category set to Interface
  • Status changed from New to Assigned
  • Assignee set to dnsmichi
  • Target version set to 1.5

#4 Updated by dnsmichi over 2 years ago

  • Subject changed from add highlight_table_rows to status.cgi, disabled via cfg option to add highlight_table_rows to status.cgi, can be disabled via cfg option

#5 Updated by mjbrooks over 2 years ago

Apparently you were more motivated for this than I thought. ;)

I will check it out as soon as I can.

#6 Updated by mjbrooks over 2 years ago

I haven't looked at it you, but I saw the pics you posted on twitter.

Would it be possible to have the highlight colors dependent on the status? They can be based on the unsaturated colors used in the TAC Header. I'm not sure having the status color completely obfuscated by the highlight is what we want.

EDIT: I like where it's going though. ;)

#7 Updated by dnsmichi over 2 years ago

i'm not a designer - it was already hard finding a good grey instead of the blue.

yes it will be possible. you might change the #defines and add the javascript string back to the code, leaving the color string out. then you'd check the current state of the service/host and assign the correct color code to it.

but since i don't have any idea on how the overlay color should look i haven't made it that modular.

#8 Updated by ricardo over 2 years ago

Hi,

can we please revert this change for 1.5 and add a reworked solution to 1.6.

Think this isn't ready for production jet.

#9 Updated by dnsmichi over 2 years ago

change the defaults to disabled in the code and the cgi.cfg - i will use and need this in 1.5.0

#10 Updated by dnsmichi over 2 years ago

  • Status changed from Assigned to Feedback
  • Assignee deleted (dnsmichi)
  • Target version changed from 1.5 to 1.6
  • % Done changed from 0 to 50

experimental stays there, but yet disabled. if someone takes the hat for 1.6. rework, feel free.

#11 Updated by dnsmichi over 2 years ago

  • Subject changed from add highlight_table_rows to status.cgi, can be disabled via cfg option to add highlight_table_rows to status.cgi
  • Assignee set to ricardo

#12 Updated by ricardo over 2 years ago

  • % Done changed from 50 to 100

reworked this feature.

used jquery, removed htables.js

please test -> dev/cgis

#13 Updated by dnsmichi over 2 years ago

ok, thanks i will have look this weekend :)

#14 Updated by ricardo over 2 years ago

forget to change this in cgi.cfg.in. added in current rbaterls/cgi

#15 Updated by dnsmichi over 2 years ago

people upgrading won't see that either way, only fresh installs will get the fresh cgi.cfg - so users need to know about the CHANGE then.

works fine at my stage, thanks.

#16 Updated by dnsmichi over 2 years ago

  • Status changed from Feedback to Resolved

thanks again for implementing that properly, ricardo.

Also available in: Atom PDF