Feature #1633

cmd.cgi is parameter order dependant

Added by insom almost 3 years ago. Updated almost 3 years ago.

Status:ResolvedStart date:06/09/2011
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:Commands
Target version:Icinga 1.x - 1.5

Description

Hi,

cmd.cgi commands which require a `host` and a `service` parameter require that the service immediately follow the host parameter. This was introduced in d4789ab7, along with multiple checkboxes (which are super!).

iWeb call cmd.cgi from Python scripts, but Python dictionaries are not ordered. We run a patch against 1.4.0 which allows one to merge `host` and `service` into one new parameter called `hostservice` - separating the two by a caret.

I'll be sending along a patch of my implementation. I don't know that it's perfect (for one thing, you can't use caret in service or host names any more), but perhaps it's a starting point.

Aaron

0001-Add-hostservice-CGI-parameter.patch Magnifier - Patch to add hostservice parameter (1.82 KB) insom, 06/09/2011 10:06 pm

Associated revisions

Revision b6fd6337
Added by ricardo almost 3 years ago

Added ability to combine host and service in one CGI parameter (Aaron Brady) #1633

refs: #1633
refs: #1120
refs: #1644

  • added parameter hostservice to cmd.cgi parameter
  • fixed dropdown, causing error when not in status list of status.cgi
  • changed dropdown from get to post, hopefully ollowing more
    hosts and services to be sent.
  • added missing Changlogentry for #1120

History

#1 Updated by insom almost 3 years ago

This patch adds the `hostservice` parameter, which is position independent.

#2 Updated by dnsmichi almost 3 years ago

  • Status changed from New to Feedback
  • Target version changed from 1.4.1 to 1.5

this is a nice feature enhancement, thanks - targetted for 1.5 though.

#3 Updated by ricardo almost 3 years ago

  • % Done changed from 0 to 100

please test in "test/cgis"

#4 Updated by dnsmichi almost 3 years ago

  • Tracker changed from Bug to Feature
  • Assignee deleted (insom)

#5 Updated by dnsmichi almost 3 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF