replace libtap with an actively developed version
|Target version:||Icinga 1.x - 1.7|
as pointed out by sven, seems to be more active development on that.
fix test_checks in t-tap, strange sigsegv all the way ...
passing a checkresult from services straight to a host
without checking that the svcdesc is null'ed leads to
rather strange behaviour. furthermore, using calloc
instead of malloc does not prevent us from initializing
all the important members which reach the inner core
functionality already set - we shouldn't fail on the
tests just because we don't know how to set variables.
#2 Updated by dnsmichi over 4 years ago
- Category set to Testing
- Status changed from Closed to Assigned
- Assignee set to dnsmichi
- Target version set to 1.7
as a matter of fact, the currently used libtap in tap/ is outdated and it seems, not developed anymore.
the one on github is actively developed, and requires some small adaptions.
plan_tests => plan
todo_start => todo
todo_end => cendtodo
meanwhile, it does not require a configure call anymore, so we can silently drop --enable-libtap in configure as well.
furthermore, the current location in tap/ is rather suspicious, as we should ship bundled libraries elsewhere. the new location will be tools/libtap with a special README.icinga file. as well as a distclean patch to the Makefile.
#3 Updated by dnsmichi over 4 years ago
tools/libtap/README.icinga libtap in Icinga ---------------- The original libtap implementation from http://jc.ngo.org.uk/trac-bin/trac.cgi/wiki/LibTap seems to have stopped development (last release 2005, autoconf 2.59. no --datarootdir). Icinga now steps onto https://github.com/zorgnax/libtap which provides active development as well as more flexibility on build systems (no configure, but plain make). This will also be place in tools/libtap as bundled library, not to confuse with the main package. For further questions on testing, please refer to the official Icinga support channels at https://www.icinga.org/support/ More information on testing strategies can be found in the Icinga wiki https://wiki.icinga.org